Size: 260
Comment:
|
Size: 2246
Comment:
|
Deletions are marked like this. | Additions are marked like this. |
Line 5: | Line 5: |
Apparently implemented <= instead of >=. Consequently one of my simple tests does not run. | Apparently you implemented <= instead of >=. This should not be a problem, however the satisfiable tests fail. It appears that you implemented the correct procedure (SAT for Addition constraints not just difference constraints) and other than the above it look good. I would like to see you about a possible better grade. If you can show me that you can modify my tests to pass, I'll give you a 20/20. |
Line 7: | Line 7: |
18 | * testSimpleSat: Failed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Failed * testAddUnsat: Passed * testAddSat: Failed Recommend: 18 |
Line 13: | Line 20: |
17 | * testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
Line 15: | Line 27: |
Recommend: 17 == Yue == You only implemented difference constraints. But a very nice program interface! * testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed 4/6 Recommend: 18 == Sadofsky == You only implemented difference constraints. * testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed 4/6 Recommend: 17 == Neo == You only implemented difference constraints. * testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed Recommend: 17 == Miao == You only implemented difference constraints. * testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed Recommend: 17 == Ramsey == You only implemented difference constraints. Passes all difference tests. * testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed Recommend: 17 |
This is remarks for grading the project:
Hodges
Apparently you implemented <= instead of >=. This should not be a problem, however the satisfiable tests fail. It appears that you implemented the correct procedure (SAT for Addition constraints not just difference constraints) and other than the above it look good. I would like to see you about a possible better grade. If you can show me that you can modify my tests to pass, I'll give you a 20/20.
- testSimpleSat: Failed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Failed
- testAddUnsat: Passed
- testAddSat: Failed
Recommend: 18
Augustyn
Implemented the book sat method which only does difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17
Yue
You only implemented difference constraints. But a very nice program interface!
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
4/6
Recommend: 18
Sadofsky
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
4/6
Recommend: 17
Neo
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17
Miao
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17
Ramsey
You only implemented difference constraints. Passes all difference tests.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17