Size: 1705
Comment:
|
Size: 2246
Comment:
|
Deletions are marked like this. | Additions are marked like this. |
Line 5: | Line 5: |
Apparently implemented <= instead of >=. Consequently one of my simple tests does not run. However it appears that he implemented the correct procedure and other than the above it look good. | Apparently you implemented <= instead of >=. This should not be a problem, however the satisfiable tests fail. It appears that you implemented the correct procedure (SAT for Addition constraints not just difference constraints) and other than the above it look good. I would like to see you about a possible better grade. If you can show me that you can modify my tests to pass, I'll give you a 20/20. |
Line 7: | Line 7: |
testSimpleSat: Failed testSimpleUnsat: Passed testDiffUnsat: Passed testDiff2Sat: Failed testAddUnsat: Passed testAddSat: Failed |
* testSimpleSat: Failed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Failed * testAddUnsat: Passed * testAddSat: Failed |
Line 14: | Line 14: |
3/6 18 |
Recommend: 18 |
Line 22: | Line 20: |
testSimpleSat: Passed testSimpleUnsat: Passed testDiffUnsat: Passed testDiff2Sat: Passed testAddUnsat: Failed testAddSat: Failed |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
Line 29: | Line 27: |
4/6 17 |
Recommend: 17 |
Line 36: | Line 32: |
You only implemented difference constraints. But a very nice program interface! Passes all difference tests. Fails x+y>=b tests and -x-y>=b tests. | You only implemented difference constraints. But a very nice program interface! |
Line 38: | Line 34: |
testSimpleSat: Passed testSimpleUnsat: Failed testDiffUnsat: Failed testDiff2Sat: Passed |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
Line 43: | Line 41: |
Although I'm not absolutely certain, I belive you are not reaching a fixpoint when you use log10 in the satisfiable method. | 4/6 |
Line 45: | Line 43: |
2/6 18 |
Recommend: 18 |
Line 51: | Line 47: |
You only implemented difference constraints. Passes all difference tests. Fails x+y>=b tests and -x-y>=b tests. | You only implemented difference constraints. |
Line 53: | Line 49: |
18 | * testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed 4/6 Recommend: 17 |
Line 59: | Line 64: |
testSimpleSat: Passed testSimpleUnsat: Passed testDiffUnsat: Passed testDiff2Sat: Passed testAddUnsat: Failed testAddSat: Failed |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
Line 66: | Line 71: |
18 | Recommend: 17 |
Line 72: | Line 77: |
testSimpleSat: Passed testSimpleUnsat: Passed testDiffUnsat: Passed testDiff2Sat: Passed testAddUnsat: Failed testAddSat: Failed |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
Line 80: | Line 85: |
18 | Recommend: 17 |
Line 86: | Line 91: |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
|
Line 87: | Line 98: |
18 |
Recommend: 17 |
This is remarks for grading the project:
Hodges
Apparently you implemented <= instead of >=. This should not be a problem, however the satisfiable tests fail. It appears that you implemented the correct procedure (SAT for Addition constraints not just difference constraints) and other than the above it look good. I would like to see you about a possible better grade. If you can show me that you can modify my tests to pass, I'll give you a 20/20.
- testSimpleSat: Failed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Failed
- testAddUnsat: Passed
- testAddSat: Failed
Recommend: 18
Augustyn
Implemented the book sat method which only does difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17
Yue
You only implemented difference constraints. But a very nice program interface!
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
4/6
Recommend: 18
Sadofsky
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
4/6
Recommend: 17
Neo
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17
Miao
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17
Ramsey
You only implemented difference constraints. Passes all difference tests.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17