Size: 1705
Comment:
|
Size: 2847
Comment:
|
Deletions are marked like this. | Additions are marked like this. |
Line 1: | Line 1: |
This is remarks for grading the project: | Everyone except Hodges implemented the Gap-Graph algorithm for SAT p 175 in the book. This works great for Difference constraints, but not for Addition constraints. However everyone who turned that in did it right. Hodges has some problems and I'd like to talk to him(I think its a him) about it. I gave him an 18because it appears like he tried to do the right algorithm. If he can show me where I need to change my tests to suit his solution I'll give him a 20. Yue went above and beyond with his interface. It looks really nice! Even though he only implemented difference constraints I gave him an 18 (90%). Everyone else got 17. If you want to bump them up than please do the same for Yue. |
Line 5: | Line 7: |
Apparently implemented <= instead of >=. Consequently one of my simple tests does not run. However it appears that he implemented the correct procedure and other than the above it look good. | Apparently you implemented <= instead of >=. This should not be a problem, however the satisfiable tests fail. It appears that you implemented the correct procedure (SAT for Addition constraints not just difference constraints) and other than the above it look good. I would like to see you about a possible better grade. If you can show me that you can modify my tests to pass, I'll give you a 20/20. |
Line 7: | Line 9: |
testSimpleSat: Failed testSimpleUnsat: Passed testDiffUnsat: Passed testDiff2Sat: Failed testAddUnsat: Passed testAddSat: Failed |
* testSimpleSat: Failed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Failed * testAddUnsat: Passed * testAddSat: Failed |
Line 14: | Line 16: |
3/6 18 |
Recommend: 18 |
Line 20: | Line 20: |
Implemented the book sat method which only does difference constraints. | You only implemented difference constraints. |
Line 22: | Line 22: |
testSimpleSat: Passed testSimpleUnsat: Passed testDiffUnsat: Passed testDiff2Sat: Passed testAddUnsat: Failed testAddSat: Failed |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
Line 29: | Line 29: |
4/6 17 |
Recommend: 17 |
Line 36: | Line 34: |
You only implemented difference constraints. But a very nice program interface! Passes all difference tests. Fails x+y>=b tests and -x-y>=b tests. | You only implemented difference constraints. But a very nice program interface! |
Line 38: | Line 36: |
testSimpleSat: Passed testSimpleUnsat: Failed testDiffUnsat: Failed testDiff2Sat: Passed |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
Line 43: | Line 43: |
Although I'm not absolutely certain, I belive you are not reaching a fixpoint when you use log10 in the satisfiable method. | 4/6 |
Line 45: | Line 45: |
2/6 18 |
Recommend: 18 |
Line 51: | Line 49: |
You only implemented difference constraints. Passes all difference tests. Fails x+y>=b tests and -x-y>=b tests. | You only implemented difference constraints. |
Line 53: | Line 51: |
18 | * testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed 4/6 Recommend: 17 |
Line 59: | Line 66: |
testSimpleSat: Passed testSimpleUnsat: Passed testDiffUnsat: Passed testDiff2Sat: Passed testAddUnsat: Failed testAddSat: Failed |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
Line 66: | Line 73: |
18 | Recommend: 17 |
Line 72: | Line 79: |
testSimpleSat: Passed testSimpleUnsat: Passed testDiffUnsat: Passed testDiff2Sat: Passed testAddUnsat: Failed testAddSat: Failed |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
Line 80: | Line 87: |
18 | Recommend: 17 |
Line 84: | Line 91: |
You only implemented difference constraints. Passes all difference tests. | You only implemented difference constraints. |
Line 86: | Line 93: |
* testSimpleSat: Passed * testSimpleUnsat: Passed * testDiffUnsat: Passed * testDiff2Sat: Passed * testAddUnsat: Failed * testAddSat: Failed |
|
Line 87: | Line 100: |
18 |
Recommend: 17 |
Everyone except Hodges implemented the Gap-Graph algorithm for SAT p 175 in the book. This works great for Difference constraints, but not for Addition constraints. However everyone who turned that in did it right.
Hodges has some problems and I'd like to talk to him(I think its a him) about it. I gave him an 18because it appears like he tried to do the right algorithm. If he can show me where I need to change my tests to suit his solution I'll give him a 20. Yue went above and beyond with his interface. It looks really nice! Even though he only implemented difference constraints I gave him an 18 (90%). Everyone else got 17. If you want to bump them up than please do the same for Yue.
Hodges
Apparently you implemented <= instead of >=. This should not be a problem, however the satisfiable tests fail. It appears that you implemented the correct procedure (SAT for Addition constraints not just difference constraints) and other than the above it look good. I would like to see you about a possible better grade. If you can show me that you can modify my tests to pass, I'll give you a 20/20.
- testSimpleSat: Failed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Failed
- testAddUnsat: Passed
- testAddSat: Failed
Recommend: 18
Augustyn
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17
Yue
You only implemented difference constraints. But a very nice program interface!
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
4/6
Recommend: 18
Sadofsky
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
4/6
Recommend: 17
Neo
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17
Miao
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17
Ramsey
You only implemented difference constraints.
- testSimpleSat: Passed
- testSimpleUnsat: Passed
- testDiffUnsat: Passed
- testDiff2Sat: Passed
- testAddUnsat: Failed
- testAddSat: Failed
Recommend: 17